MODS.DB9.DK

[AlleyKat]

sorry, I don't quite get that... the removed ))) should fit what I'd edited in the lines before (also included in the above). Hmm and maybe it has something to do with either php or mysql version, but we really couldn't get it working any other way. However it seems to be running perfectly with the above edit, so I assume that it's ok.

[jupro]

Hi there,

I've had the same problem with this mod (actually I've had a few problems with it - and can't seem to get much help at all).

I've added your code changes, but it still does not work for me.

Anyone with ideas on this?

Thanks very much.

[ChristianR]

can someone post the exact code that needs to be changed to make time work on specific dates?

i.e. 9am to 10pm on 3rd october

[AlleyKat]

jupro > did it work (show banners) without any time set at all?

ChristianR > I think all I did was what I've posted in first post. But maybe Niels knows better, I didn't quite understand what he meant in his post.

[ChristianR]

didn't work..

Code: Select all

General Error
 
Couldn't get banners data

DEBUG MODE

SQL Error : 1064 You have an error in your SQL syntax near 'ORDER BY banner_spot,banner_weigth*SUBSTRING(RAND(),6,2) DESC' at line 8

SELECT DISTINCT banner_id, banner_name, banner_spot, banner_description, banner_forum, banner_type, banner_width, banner_height, banner_filter FROM phpbb_banner WHERE banner_active AND IF(banner_level_type,IF(banner_level_type=1,2<=banner_level,IF(banner_level_type=2,2>=banner_level,2<>banner_level)),banner_level=2) AND (banner_timetype=0 OR (( 1841 BETWEEN time_begin AND time_end) AND ((banner_timetype=2 OR (( 1 BETWEEN date_begin AND date_end) AND banner_timetype=4) OR (( 20050221 BETWEEN date_begin AND date_end) AND banner_timetype=6) ) ORDER BY banner_spot,banner_weigth*SUBSTRING(RAND(),6,2) DESC

Line : 396
File : path to forum\includes\page_header.php


[omi]

Is this relevant in 1/3/7

[mgutt]

seems to work:

Code: Select all

$sql = "SELECT DISTINCT banner_id, banner_name, banner_spot, banner_url, banner_description, banner_forum, banner_type, banner_width, banner_height, banner_filter FROM ".BANNERS_TABLE ."
      WHERE banner_active
      AND IF(banner_level_type,IF(banner_level_type=1,".intval($sql_level)."<=banner_level,IF(banner_level_type=2,".intval($sql_level).">=banner_level,".intval($sql_level)."<>banner_level)),banner_level=".intval($sql_level).")
      AND (banner_timetype=0
      OR (( $hour_now BETWEEN time_begin AND time_end) AND banner_timetype=2)
      OR (( $week_now BETWEEN date_begin AND date_end) AND banner_timetype=4)
      OR (( $date_now BETWEEN date_begin AND date_end) AND banner_timetype=6)
      ) ORDER BY banner_spot,banner_weigth*SUBSTRING(RAND(),6,2) DESC";

doesn't test an ending time.. in february one of the banners will be deactivated.. i will be back then

[bjpembo]

seems to work:

This does seem to work, it fixed my problems as well. I tested starting and ending dates and times and things seem in order.

to clarify the above post.....

includes/page_header.php

Replace this....

Code: Select all

$sql = "SELECT DISTINCT banner_id, banner_name, banner_spot, banner_description, banner_forum, banner_type, banner_width, banner_height, banner_filter FROM ".BANNERS_TABLE ."
      WHERE banner_active
      AND IF(banner_level_type,IF(banner_level_type=1,".intval($sql_level)."<=banner_level,IF(banner_level_type=2,".intval($sql_level).">=banner_level,".intval($sql_level)."<>banner_level)),banner_level=".intval($sql_level).")
      AND (banner_timetype=0
      OR (( $hour_now BETWEEN time_begin AND time_end) AND ((banner_timetype=2
      OR (( $week_now BETWEEN date_begin AND date_end) AND banner_timetype=4)
      OR (( $date_now BETWEEN date_begin AND date_end) AND banner_timetype=6)
      )))) ORDER BY banner_spot,banner_weigth*SUBSTRING(RAND(),6,2) DESC";

With this....

Code: Select all

$sql = "SELECT DISTINCT banner_id, banner_name, banner_spot, banner_url, banner_description, banner_forum, banner_type, banner_width, banner_height, banner_filter FROM ".BANNERS_TABLE ."
      WHERE banner_active
      AND IF(banner_level_type,IF(banner_level_type=1,".intval($sql_level)."<=banner_level,IF(banner_level_type=2,".intval($sql_level).">=banner_level,".intval($sql_level)."<>banner_level)),banner_level=".intval($sql_level).")
      AND (banner_timetype=0
      OR (( $hour_now BETWEEN time_begin AND time_end) AND banner_timetype=2)
      OR (( $week_now BETWEEN date_begin AND date_end) AND banner_timetype=4)
      OR (( $date_now BETWEEN date_begin AND date_end) AND banner_timetype=6)
      ) ORDER BY banner_spot,banner_weigth*SUBSTRING(RAND(),6,2) DESC";

[/code]