MODS.DB9.DK

[cYbercOsmOnauT]

You understood me wrong.. and.. btw... I moaned to them I wrote a bugreport. I am not disrespecting the work of the author. I just told you that the way the author goes disables the setting of $board_config['session_length'] without needing to do. He/You (dunno who wrote the mod) should change that part of the modscript so that this config is also used right from the forum-script.

And hey.. taking, taking? Check my nick here or on other phpbb-boards. I am no "just taker". I help where I can when I find time.

Why do you get that upset? Is it wrong to say "hey thats no good way"? Does this make someone "know everything"? I think not mate.

Think about my words. The world is not just full of "well done", somtimes you also hear a "should go better this way". I guess you are old enough to take it as a "harder" help.

Regards...

[acoolwelshbloke]

I don't know why you guys don't read and understand the code written by the phpbb-coders. I now saw two different "solutions" for the problem with 2.0.18 and the Last Visit Mod. Both of them turn the new "Session Length"-Entry on the Configuration (ACP) to nonsense. Because (with your code) it doesn't matter what the admin writes in this field. The sessions get deleted after two days.

The 100% right solution is:

Code: Select all

#
#-----[ FIND ]------------------------------------------------
#
}

//
// Delete expired sessions
//

#
#-----[ FIND ]------------------------------------------------
#
$sql = 'DELETE FROM ' . SESSIONS_TABLE . '
   WHERE session_time < ' . (time() - (int) $board_config['session_length']) . "
       AND session_id <> '$session_id'";

#
#-----[ REPLACE WITH ]--------------------------------
#
$sql = 'DELETE FROM ' . SESSIONS_TABLE . '
   WHERE session_time < ' . (time() - (86400 * (int) $board_config['session_length']))) . "
       AND session_id <> '$session_id'";

All the coders forgot was to calculate the value of $board_config['session_length'] from days to seconds. Sorry when I sound a bit upset but I dislike solutions which disable functions without needing to do.

Cheers,
Tekin

Then why come here to moan about it?

This mod is designed around phpbb, it is not up to the author of this mod to fix the bugs in phpbb.....

if it is a bug then phpbb will sort it and this mod will be re-written if needed around those modifications!

Ohhhh and by the way my sessions work just fine so I don't agree with what your saying personally.

Although i am from time to time proven wrong I doubt I will be this time.

[cYbercOsmOnauT]

So let me say it this way: The mod is not up to date anymore. There is a new config value which the mod doesn't take care of. The mod disables this config value.

Better? :p

And btw... I just came here because someone send me here to take a look at that solution.

Good night (or should I say morning? )

Tekin

[acoolwelshbloke]

Well why not say that to start with in the manner you just replied with?

We all welcome comments from others about how to go about updating and fixing mods that don't work anymore.

We know this mod needs updating and the fix posted above as well by others is a temp fix until the author re-writes the mod the way he wants it.

If you have the answer to hand then post it and the author no doubt will look at it and if correct may even implement it in the mod, and don't say you have provided it above as that script will not work with this mod. It may work with phpbb prior to this mod being installed but it wll not work with this mod.

regards

[Beeveer]

Can you just stop with shouting and pissing everybody off. It just starts to get annoying.

I do understand that other solutions are maybo not the best, but they work, and that is the first thing people need.

I don't want to see people shouting and using bad words against other users. Both solutions work, but the one is customable.

And now don't think I'm stupid, I've worked with too many mods and customised too much of them for that.

[acoolwelshbloke]

Who is shouting?

This situation has been resolved......

Who are you talking to by the way?

If it is me then I was refering to the fact that someone was saying that we and the author of this mod did not do a good job and we need to read better in the future!

It's like me purchasing a ford and walking into a BMW garage screaming about how my wheel fell of and that they should do a better job next time. Even though they have nothing to do with the original design.

Anyway guy's let's leave sleeping dogs lie and enjoy the mod.

[BillyBobBongo]

I downloaded this file for use on my 2.0.18 board and I'm getting this error

Parse error: parse error in c:\program files\easyphp1-8\www\forum\includes\sessions.php on line 398

I've made all the changes but I can't seem to discover what's wrong with my sessions.php file. I noticed additional changes to this part

Code: Select all

#
#-----[ FIND ]------------------------------------------------
#
}

//
// Delete expired sessions
//

#
#-----[ FIND ]------------------------------------------------
#
$sql = 'DELETE FROM ' . SESSIONS_TABLE . '
   WHERE session_time < ' . (time() - (int) $board_config['session_length']) . "
       AND session_id <> '$session_id'";

#
#-----[ REPLACE WITH ]--------------------------------
#
$sql = "DELETE FROM " . SESSIONS_TABLE . "
   WHERE UNIX_TIMESTAMP() - session_time >=172800
       AND session_id <> '$session_id'";

and made those but I'm still having no luck! Any ideas?!

[BillyBobBongo]

I used my existing sessions.php file (2.0.17) and upgraded as per instructions on phpBB.com. I then added the above modification, since the upgraded removed it, and then uploaded it to my (offline) server and it worked! I just want to ensure that any other changes need to be made!?