MODS.DB9.DK

[acoolwelshbloke]

thanks my friend you rule at php.(offtopic your site is gr8!!!)
I tried your sessions.php and you fixed some things but it was a minor problem tha kept it from workink ,
I searched all the other mods I installed and fortunately they did not alter sessions php (EasyMOD 0.3.0 View All Posts Sorted By Time 1.0.0 by pentapenguin - Separate Announcements & Sticky 2.0.0 by Aiencran and ImageShack Mod )

Can you do me a favour and tell me what the problem your having now is?

As feldon was helping you originally and I'm unsure of what is actually going on?

Thanks

[acoolwelshbloke]

Hmmm, I downloaded that zip yesterday to try it on a fresh install of phpbb v2.0.18 and that code was not in there..

If you alter the code your way you are going to have problems with your phpbb.

I do not understand what your saying cause the code is really the same as yours except that i did not do the

Code: Select all

$sql = "DELETE FROM " . SESSIONS_TABLE . "
   WHERE UNIX_TIMESTAMP() - session_time >=172800
       AND session_id <> '$session_id'";

I will be checking this out further with my friend who IS a programer to see if there is anything wrong with this..
We both seam to be around to help people and with that I wish you and family, Happy Holidays..

Ok I'll try to explain what the problem is, Your install text does not tell people to alter the following code:

Code: Select all

#
#-----[ FIND ]------------------------------------------------
#
}

//
// Delete expired sessions
//

#
#-----[ FIND ]------------------------------------------------
#
$sql = 'DELETE FROM ' . SESSIONS_TABLE . '
   WHERE session_time < ' . (time() - (int) $board_config['session_length']) . "
       AND session_id <> '$session_id'";

#
#-----[ REPLACE WITH ]--------------------------------
#
$sql = "DELETE FROM " . SESSIONS_TABLE . "
   WHERE UNIX_TIMESTAMP() - session_time >=172800
       AND session_id <> '$session_id'";

So if people do it your way their code will stay as the following which is the phpbb default:

Code: Select all

$sql = 'DELETE FROM ' . SESSIONS_TABLE . '
   WHERE session_time < ' . (time() - (int) $board_config['session_length']) . "
       AND session_id <> '$session_id'";

If you do that you will get problems trust me I already been there and done it!

You also say in a post yet it is not in your install script to do the following:

Code: Select all

#-----[ FIND ]------------------------------------------------
#
}

//
// Delete expired sessions
//

#
#-----[ FIND ]------------------------------------------------
#
$sql = 'DELETE FROM ' . SESSIONS_TABLE . '
   WHERE session_time < ' . (time() - (int) $board_config['session_length']) . "
       AND session_id <> '$session_id'";

#
#-----[ REPLACE WITH ]--------------------------------

The code really is:

Code: Select all

/**
* Removes expired sessions and auto-login keys from the database
*/
function session_clean($session_id)
{
   global $board_config, $db;
       
   //
   // Delete expired sessions

???
Anyway let's just leave it at a difference of opinions as this thread is getting filled with posts that will just confuse people!

Hell I'm even starting to get confussed!

Ohhhh MERRY CHRISTMAS EVERYONE!

[DVD_GR]

to sum up because you are right the thread is getting complex!!
I get
Critical Error

IN-LINE FIND FAILED: In file [includes/sessions.php] could not find:

user_lastvisit = $last_visit

MOD script line #551 :: FAQ :: Report

in the attached sessions.php

[acoolwelshbloke]

Try this one!

[DVD_GR]

one step from working,please attach someone its index.php because I've done something wrong,to see the diffirences!
thanks for the help guys!
merry christmas!!

[Billy2423]

U should just post the error msg and we could just go from there but here is a new index with just this installed..

[acoolwelshbloke]

My index is heavily modded so no point me posting mine as it will totally confuse you. Best thing to do is go to phpbb.com and download phpbb open the index.php file and install the last visit mod to that file and try that or you can use that to see the difference between yours and that!

EDIT: Hey good timing billy, posted at the same time there!

Use billy's index.php

[DVD_GR]

I need the part which is near the 284line of index.php

Code: Select all

      'FORUM_IMG' => $images['forum'],
      'FORUM_NEW_IMG' => $images['forum_new'],
      'FORUM_LOCKED_IMG' => $lang['Forum'],
      'L_TOPICS' => $lang['Topics'],
      'L_REPLIES' => $lang['Replies'],
      'L_VIEWS' => $lang['Views'],


there I need to see how you apllied the first order of the mod,
because I failed to do it correct and rolled back only index.php to keep the forum working,while the other parts of the mod are ready