MODS.DB9.DK

[aric]

Actually, I got it to work by simply adding the { and } and commenting these lines to remove them...

Code: Select all

//   $sql = "SELECT DISTINCT g.group_id, g.group_name
   //   FROM ".GROUPS_TABLE . " g, ".USER_GROUP_TABLE . " ug
   //   WHERE g.group_single_user <> 1
   //      AND (
   //         (g.group_allow_pm='".AUTH_MOD."' AND g.group_moderator = '" . $userdata['user_id']."') OR 
   //         (g.group_allow_pm='".AUTH_ACL."' AND ug.user_id = " . $userdata['user_id'] . " AND ug.group_id = g.group_id ) OR
   //         (g.group_allow_pm='".AUTH_REG."')       
   //      )" ;


So now that whole section looks like this:

Code: Select all

// Start add - Custom mass PM MOD
include($phpbb_root_path . 'language/lang_' . $board_config['default_lang'] . '/lang_mass_pm.' . $phpEx);

if ( $userdata['user_id'] != ANONYMOUS )
{
   if ( $userdata['user_level'] == ADMIN )
   {
      $mass_pm_img = '<a href="' . append_sid("groupmsg.$phpEx") . '"><img src="' . $images['mass_pm'] . '" border="0" alt="' . $lang['Mass_pm'] . '" /></a>';
    } else
    {
   //   $sql = "SELECT DISTINCT g.group_id, g.group_name
   //   FROM ".GROUPS_TABLE . " g, ".USER_GROUP_TABLE . " ug
   //   WHERE g.group_single_user <> 1
   //      AND (
   //         (g.group_allow_pm='".AUTH_MOD."' AND g.group_moderator = '" . $userdata['user_id']."') OR 
   //         (g.group_allow_pm='".AUTH_ACL."' AND ug.user_id = " . $userdata['user_id'] . " AND ug.group_id = g.group_id ) OR
   //         (g.group_allow_pm='".AUTH_REG."')       
   //      )" ;
      if( !$g_result = $db->sql_query($sql) ) message_die(GENERAL_ERROR, "Could not select group names!", __LINE__, __FILE__, $sql);
      {
      $group_list = $db->sql_fetchrowset($g_result);
        }
       
      if( !empty($group_list) )
      {
         $mass_pm_img = '<a href="' . append_sid("groupmsg.$phpEx") . '"><img src="' . $images['mass_pm'] . '" border="0" alt="' . $lang['Mass_pm'] . '" /></a>';
      }
    }
}
// End add - Custom mass PM MOD


I've tested it for both regular users and admins and the mod works as it should (admins see the link to the mass PM area, regular users do not).

Aric

[Zed Oscuro]

Like mine!

Now it works... but.. the code "removed" isn't useful?

[glson]

I have the same problem, after removed this code it's working, this code isn't useful?

[aric]

Sadly, I'm no PHP expert, but yes, it seems to work fine without it.

Aric

[Niels]

I will post a updated version, witch fix this prob.

[DragonFire*_*]

I too had this same problem. I commented out the SQL statement mentioned in the previous post and the problem disappeared. The if statement after the SQL statement looks correct and does not need the { and } around the following statement.

[Niels]

latest version should not have this isue anymore, please follow the upgrade path instead...

[DragonFire*_*]

I just looked at the changes to the new version. I found that same problem and corrected it manually. I was just going to let everyone know here about it.

Glad to see you fixed it.