Installation worked fine, banner not showing on Forum

a complete banner management system, any number of banners can be added
Forum rules
The content in this forum is dated Dec. 21 2005 and can be used as Archive only. This Forum is LOCKED and READ ONLY !

Installation worked fine, banner not showing on Forum

Postby real843 on Mon 03. May, 2004 11:43

Hi. I downloaded the complete banner hack and installed it with easy mod. The installation seemed to work fine and I get the new options for banners on the ACP. After I add a new banner and doublecheck all settings it won't show up on my forum. What am I doing wrong?

My forum adress is www.pokersite.dk/forym/index.php.

any help is appreciated

thanks
real843
Poster
Poster
 
Posts: 1
Joined: Mon 03. May, 2004 01:22

Postby rejj on Tue 16. Aug, 2005 23:26

I've got the same problem!
Everything seems to be fine, but after adding a banner it doesn't show in the forum!
I've taken a look at the database, and it seems fine.

Please help!!
rejj
Poster
Poster
 
Posts: 19
Joined: Tue 15. Apr, 2003 11:28

Postby Beeveer on Wed 17. Aug, 2005 18:32

This is fixed in the download available over here, the download from phpBBHacks has to be updated.
User avatar
Beeveer
brilliant supporter
 
Posts: 264
Joined: Tue 30. Nov, 2004 19:13
Location: Boskoop, South-Holland, the Netherlands

Postby ModBo on Sun 04. Sep, 2005 23:17

After installing this mod (v.1.3.7 located here) no banner was shown in forum.
Imagesize in ACP was set to zero/zero (width/height) to view image in full size.

Setting this values up to the correct image size fixed the problem and banner appeared in forum.

Looking in source code, I made the following changes:

page_header.php
Code: Select all
#
# --- [ FIND ] ---
#
         $banner_size = ($banners[$i]['banner_width']<>'') ? ' width="'.$banners[$i]['banner_width'].'"' : '';
         $banner_size .= ($banners[$i]['banner_height']<>'') ? ' height="'.$banners[$i]['banner_height'].'"' : '';

#
# --- [ REPLACE, WITH ] ---
#
         $banner_size = ($banners[$i]['banner_width']<>0) ? ' width="'.$banners[$i]['banner_width'].'"' : '';
         $banner_size .= ($banners[$i]['banner_height']<>0) ? ' height="'.$banners[$i]['banner_height'].'"' : '';


admin_banners.php
Code: Select all
#
# --- [ FIND ] ---
#
      $banner_size = ($banners[$i]['banner_width']<>'') ? 'width="'.$banners[$i]['banner_width'].'"' : '';
      $banner_size .= ($banners[$i]['banner_height']<>'') ? ' height="'.$banners[$i]['banner_height'].'"' : '';

#
# --- [ REPLACE, WITH ] ---
#
                 $banner_size = ($banner_info['banner_width']<>0) ? ' width="'.$banner_info['banner_width'].'"' : '';
      $banner_size .= ($banner_info['banner_height']<>0) ? ' height="'.$banner_info['banner_height'].'"' : '';


With these changes:
- banner appears in forum, size like ACP settings, by zero/zero fullsize
- ACP Image preview appears in correct size


Any hints?
ModBo
Poster
Poster
 
Posts: 6
Joined: Fri 29. Oct, 2004 07:48

Postby Niels on Mon 05. Sep, 2005 01:57

I'll take a look, seam like you are right
(if a how-to is EM ready, it will mostly be bullet prof, since a machine is more picky than a human. :D)
User avatar
Niels
Poster
Poster
 
Posts: 4390
Joined: Sat 27. Jul, 2002 15:46


Return to Complete banner [2.0.6/EM]

Who is online

Users browsing this forum: No registered users and 1 guest

cron